Re: [PATCH v2] iio: light: apds9306: fix default sampling frequency definition

From: Tsz Shan Chan

Date: Thu Sep 03 2026 - 21:18:33 EST


On Thu, Sep 03, 2026 at 10:48:27AM +0300, Andy Shevchenko wrote:
> On Thu, Sep 03, 2026 at 05:05:35PM +1000, Tsz Shan Chan wrote:
> > APDS9306_SAMP_FREQ_10HZ is defined as 0.
> >
> > According to the datasheet (Broadcom AV02-4755EN,
> > https://docs.broadcom.com/doc/AV02-4755EN, page 11, ALS_MEAS_RATE),
>
> Make it a tag
>
> > bits[2:0] set the measurement rate:
> > - 000: 25ms (40Hz)
> > - 001: 20ms (20Hz)
> > - 010: 100ms (10Hz)
> >
> > Change APDS9306_SAMP_FREQ_10HZ from 0 to 2 to write the correct value
> > for 10Hz.
>
> Datasheet: $URL
>
> > Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")
> > Signed-off-by: Tsz Shan Chan <tchan@xxxxxxxxxxxxxx>
>
> With that being addressed,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

Will fix it in v3. Thanks