Re: [PATCH net-next] octeontx2-pf: report port connector type in ethtool link ksettings

[Ratheesh Kannoth]

On 2026-09-04 at 13:29:24, netdev-bot+sashiko@xxxxxxxxxx (netdev-bot+sashiko@xxxxxxxxxx) wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> - [Medium] otx2_get_link_ksettings()
>   (drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c:1235)…
>
> --
>
> octeontx2-pf: report port connector type in ethtool link ksettings

> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260901045857.2779326-1-rkannoth%40marvell.com

i think, below sole issue can be ignored.

+---+----------+--------+----------------------+---------------------------------------------------+
| # | Severity | Status | Location             | Issue                                             |
+===+==========+========+======================+===================================================+
| 1 | Medium   | New    | otx2_get_link_ksettin| Raw rsp->fwdata.port (u64 firmware field) is      |
|   |          |        | s()                  | assigned directly to cmd->base.port (__u8 ethtool |
|   |          |        | drivers/net/ethernet/| PORT_* field) with no translation, bounds check, o|
|   |          |        | arvell/octeontx2/nic/| validity gate.                                    |
|   |          |        | tx2_ethtool.c:1235   |                                                   |
+---+----------+--------+----------------------+---------------------------------------------------+