Re: [PATCH net-next] octeontx2-pf: report port connector type in ethtool link ksettings

[Simon Horman]

On Fri, Sep 04, 2026 at 02:31:23PM +0530, Ratheesh Kannoth wrote:
> On 2026-09-04 at 13:29:24, netdev-bot+sashiko@xxxxxxxxxx (netdev-bot+sashiko@xxxxxxxxxx) wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue(s) to consider:
> >
> > Critical: 0 · High: 0 · Medium: 1 · Low: 0
> >
> > - [Medium] otx2_get_link_ksettings()
> >   (drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c:1235)…
> >
> > --
> >
> > octeontx2-pf: report port connector type in ethtool link ksettings
> 
> > Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260901045857.2779326-1-rkannoth%40marvell.com
> 
> i think, below sole issue can be ignored.

I'm assuming this is because the firmware always returns valid ethtool values.
If so, it might be worth spelling that out in the commit message.
But I'm not going to get hung up on that.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

> 
> +---+----------+--------+----------------------+---------------------------------------------------+
> | # | Severity | Status | Location             | Issue                                             |
> +===+==========+========+======================+===================================================+
> | 1 | Medium   | New    | otx2_get_link_ksettin| Raw rsp->fwdata.port (u64 firmware field) is      |
> |   |          |        | s()                  | assigned directly to cmd->base.port (__u8 ethtool |
> |   |          |        | drivers/net/ethernet/| PORT_* field) with no translation, bounds check, o|
> |   |          |        | arvell/octeontx2/nic/| validity gate.                                    |
> |   |          |        | tx2_ethtool.c:1235   |                                                   |
> +---+----------+--------+----------------------+---------------------------------------------------+