Re: [PATCH v2 00/11] drm/panel: Add 5 DDIC panel drivers for 14 Sony phones

[Marijn Suijten]

Hi Linus,

On 2026-09-03 00:22:41, Linus Walleij wrote:
> Hi Marijn,
> 
> On Mon, Dec 22, 2025 at 12:32 AM Marijn Suijten
> <marijn.suijten@xxxxxxxxxxxxxx> wrote:
> 
> > This is the second version of a largely reshaped series that brings 5
> > new DDIC panel drivers (4 Samsung, 1 LGD) that are compatible with 14
> > Sony phones:
> 
> What's up with this series?

This is repeatedly blocked on the request to factor out a generic Samsung panel
library.  While commands look very similar across drivers, the same commands
are given (sometimes) different names [1] and without spec I simply don't feel
comfortable writing such a library as that'd sound like claiming I definitively
know exactly what each of those commands mean / are named.  I don't.

[1]: https://lore.kernel.org/linux-arm-msm/aU6XXi2HmgjZY8CY@xxxxxxxxxxxxxx/

And I'd argue that DRM/MSM has seen a lot of breakage especially around the
DSC and dual-DSI paths that my panels/devices rely on [2], turning a simple
rebase-and-test in a multi-evening debug session.

[2]: https://lore.kernel.org/linux-arm-msm/?q=f%3Amarijn+fixes+dsc

> I am officially a fan of these drivers and I liked the work done so far
> a lot, is there something in particular stalling these from rebasing
> and merging?

And there have been many small comments left and right - including my own
observations and self-review - that all need to get addressed.  Not a lot of
work, but they add up and it's easy enough to miss something which will make a
reviewer "unhappy" ;)

Coincidentally I submitted 10 of the 14 Sony devices to postmarketOS just last
week, specifically as an extra motivator to show the world that we can truly
run all these devices with completely functional panels straight from mainline.
I'll definitely be submitting a (rebased) v3 to drive that, but it might take a
little more time.

- Marijn