Re: [PATCH v9 1/2] i2c: mux: Factor out channel node lookup

From: Peter Rosin

Date: Sat Sep 05 2026 - 01:46:59 EST


Den Thu, Sep 03, 2026 at 10:58:53PM +0300, skrev Andy Shevchenko:
> On Thu, Sep 03, 2026 at 12:40:55PM -0700, Ahmad Byagowi wrote:
> > Move the existing Device Tree channel-node lookup into a helper in
> > preparation for using generic firmware-node operations.
> >
> > This is a pure refactoring with no functional change.
>
> ...
>
> > +static struct device_node *
> > +i2c_mux_get_channel_node(struct i2c_mux_core *muxc, u32 chan_id)
> > +{
> > + struct device_node *dev_node;
> > + struct device_node *mux_node, *child;
>
> Now all three can be defined in a single line.

They could, but three is a crowd. So, if you bother to send an update,
please use one declaration per line instead to make future diffs
clearer.

Cheers,
Peter