Re: [PATCH v9 1/2] i2c: mux: Factor out channel node lookup
From: Andy Shevchenko
Date: Sat Sep 05 2026 - 03:49:10 EST
On Sat, Sep 05, 2026 at 07:46:36AM +0200, Peter Rosin wrote:
> Den Thu, Sep 03, 2026 at 10:58:53PM +0300, skrev Andy Shevchenko:
> > On Thu, Sep 03, 2026 at 12:40:55PM -0700, Ahmad Byagowi wrote:
...
> > > + struct device_node *dev_node;
> > > + struct device_node *mux_node, *child;
> >
> > Now all three can be defined in a single line.
>
> They could, but three is a crowd. So, if you bother to send an update,
> please use one declaration per line instead to make future diffs
> clearer.
True, but it can reduce churn between these two patches if placed on
a single line. Whatever, it's a bikeshedding, so go with what Peter
prefers (as he is a maintainer IIRC of this code).
--
With Best Regards,
Andy Shevchenko