Re: [PATCH 2/8] i2c: omap: Remove unused is_rdr and is_xdr variables

[Andreas Kemnade]

On Fri, 4 Sep 2026 08:12:46 -0500
Andrew Davis <afd@xxxxxx> wrote:

> These are passed into omap_i2c_{receive,transmit}_data() but are never
> used, remove them.
> 
> Signed-off-by: Andrew Davis <afd@xxxxxx>

Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-omap.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 72f979eec7311..68b0a043f1e51 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -993,8 +993,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *omap)
>  	return 0;
>  }
>  
> -static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes,
> -		bool is_rdr)
> +static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes)
>  {
>  	u16		w;
>  
> @@ -1014,8 +1013,7 @@ static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes,
>  	}
>  }
>  
> -static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes,
> -		bool is_xdr)
> +static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes)
>  {
>  	u16		w;
>  
> @@ -1119,7 +1117,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
>  					OMAP_I2C_BUFSTAT_REG) >> 8) & 0x3F;
>  			}
>  
> -			omap_i2c_receive_data(omap, num_bytes, true);
> +			omap_i2c_receive_data(omap, num_bytes);
>  			omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RDR);
>  			continue;
>  		}
> @@ -1130,7 +1128,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
>  			if (omap->threshold)
>  				num_bytes = omap->threshold;
>  
> -			omap_i2c_receive_data(omap, num_bytes, false);
> +			omap_i2c_receive_data(omap, num_bytes);
>  			omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RRDY);
>  			continue;
>  		}
> @@ -1142,7 +1140,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
>  			if (omap->fifo_size)
>  				num_bytes = omap->buf_len;
>  
> -			ret = omap_i2c_transmit_data(omap, num_bytes, true);
> +			ret = omap_i2c_transmit_data(omap, num_bytes);
>  			if (ret < 0)
>  				break;
>  
> @@ -1157,7 +1155,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
>  			if (omap->threshold)
>  				num_bytes = omap->threshold;
>  
> -			ret = omap_i2c_transmit_data(omap, num_bytes, false);
> +			ret = omap_i2c_transmit_data(omap, num_bytes);
>  			if (ret < 0)
>  				break;
>