[PATCH bpf v2 0/3] bpf,tcp: Fix bpf_sock_destroy() on TIME_WAIT and listener socks
From: Jiayuan Chen
Date: Sun Sep 06 2026 - 03:42:15 EST
Fix two bugs in bpf_sock_destroy(). One is an out-of-bounds read of
sk->sk_protocol on TIME_WAIT and NEW_SYN_RECV socks, since the field is
not in struct sock_common. The other is a might_sleep splat when
destroying a listener with children in its accept queue, the
cond_resched() in inet_csk_listen_stop() runs under the iterator's
rcu_read_lock(). Patch 3 adds a subtest for each.
v1 -> v2:
- Patch 1: fix the return comment too.
- Patch 2: new.
- Selftest: server recv()s EOF before close so the FINs can't cross,
comment style, keep the blank line before RUN_TESTS(), add the
tcp_listen_pending subtest.
v1: https://lore.kernel.org/bpf/20260903125306.299943-1-jiayuan.chen@xxxxxxxxx/
Jiayuan Chen (3):
bpf: Fix out-of-bounds read of sk_protocol in bpf_sock_destroy()
tcp: Skip cond_resched() in inet_csk_listen_stop() under BPF context
selftests/bpf: Test bpf_sock_destroy() on TIME_WAIT and listener socks
net/core/filter.c | 13 +-
net/ipv4/inet_connection_sock.c | 3 +-
.../selftests/bpf/prog_tests/sock_destroy.c | 119 ++++++++++++++++++
.../selftests/bpf/progs/sock_destroy_prog.c | 30 +++++
4 files changed, 160 insertions(+), 5 deletions(-)
--
2.43.0