Re: [PATCH 0/7] ASoC: mediatek: mt8188: Improve error handling
From: Cezary Rojewski
Date: Tue Sep 08 2026 - 16:05:57 EST
On 9/7/2026 2:03 PM, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Hi all,
>
> This series improves error handling in several parts of the MT8188 AFE
> driver.
> Propagate errors from clock, regmap, and runtime resume operations,
> remove redundant probe error messages, and fix clock cleanup on
> registration failure.
>
> Compile-tested only.
>
> Best regards,
> Phuc
>
> bui duc phuc (7):
> ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate clock initialization
> errors
> ASoC: mediatek: mt8188: mt8188-afe-clk: Handle tuner clock enable
> errors
> ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate regmap update errors
> ASoC: mediatek: mt8188: mt8188-afe-clk: Handle clock enable errors
> ASoC: mediatek: mt8188: mt8188-afe-pcm: Handle runtime resume errors
> ASoC: mediatek: mt8188: mt8188-afe-pcm: Drop redundant probe error
> messages
> ASoC: mediatek: mt8188: fix clk leak on error in audsys_clk_register
>
> sound/soc/mediatek/mt8188/mt8188-afe-clk.c | 115 +++++++++++++-----
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 34 ++++--
> sound/soc/mediatek/mt8188/mt8188-audsys-clk.c | 12 +-
> 3 files changed, 113 insertions(+), 48 deletions(-)
>
Yet another bunch of welcomed changes though at this point I'd expect
someone from Mediatek to participate and start testing the error paths.
Some permissiveness might have been intentional but we won't know until
someone from their dev team ACKs or NAKs.
Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>