Re: [PATCH v9 6/6] selftests/mm: add a GUP selftest

From: Muhammad Usama Anjum

Date: Thu Sep 10 2026 - 03:54:51 EST


On 09/09/2026 6:34 pm, Mark Brown wrote:
> On Wed, Sep 09, 2026 at 07:03:59PM +0200, David Hildenbrand (Arm) wrote:
>
>>>> 2) Move it to tools/mm/modules or sth like that.
>
> ...
>
>>> This is an interesting change. We can keep this open for discussion
>>> here. If required, I can work on this in the future.
>
>> Yes, we should in general try moving all test modules out of the core.
>
> If you're working on this please make sure to take a look at how the
> various automated testing systems cope with modules built under
> selftests (personally I think everything I care about uses tuxmake
> builds, but there's other stuff out there). I think the answer for a
> bunch of them right now is badly, but I didn't actually go check.

There is huge discussion in the past on converting test modules into
kunit modules [1]. Selftests is not a correct place to keep kernel modules.
People have moved a lot of such modules. But new test modules get
added over time again.

[1] https://lore.kernel.org/all/20250207-bitmap-kunit-convert-v1-0-c520675343b6@xxxxxxxxx/

--
Thanks,
Usama