Re: [PATCH v9 6/6] selftests/mm: add a GUP selftest

[David Hildenbrand (Arm)]

On 9/10/26 09:53, Muhammad Usama Anjum wrote:
> On 09/09/2026 6:34 pm, Mark Brown wrote:
>> On Wed, Sep 09, 2026 at 07:03:59PM +0200, David Hildenbrand (Arm) wrote:
>>
>>
>> ...
>>
>>
>>> Yes, we should in general try moving all test modules out of the core.
>>
>> If you're working on this please make sure to take a look at how the
>> various automated testing systems cope with modules built under
>> selftests (personally I think everything I care about uses tuxmake
>> builds, but there's other stuff out there).  I think the answer for a
>> bunch of them right now is badly, but I didn't actually go check.
> 
> There is huge discussion in the past on converting test modules into
> kunit modules [1]. Selftests is not a correct place to keep kernel modules.

I don't care where we move them, but mm/ and lib/ is *certainly not* the right
place for MM specific test modules.

Anyhow, I think converting stuff to kunit makes sense. I am not sure if that is
really applicable to e.g., gup_tests though.

-- 
Cheers,

David