Re: [PATCH v2 3/5] proc/task_mmu: remove special-casing of smap_gather_stats() start parameter

[Suren Baghdasaryan]

On Thu, Sep 10, 2026 at 9:09 AM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> On Thu, Sep 10, 2026 at 9:01 AM David Hildenbrand (Arm)
> <david@xxxxxxxxxx> wrote:
> >
> > On 9/10/26 17:45, Suren Baghdasaryan wrote:
> > > On Thu, Sep 10, 2026 at 12:41 AM David Hildenbrand (Arm)
> > > <david@xxxxxxxxxx> wrote:
> > >>
> > >> On 9/9/26 23:51, Suren Baghdasaryan wrote:
> > >>> On Wed, Sep 9, 2026 at 12:16 PM David Hildenbrand (Arm)
> > >>> <david@xxxxxxxxxx> wrote:
> > >>>
> > >>> Ok, just want to make sure I'm not missing something subtle.
> > >>>
> > >>>
> > >>> Ah, good to know.
> > >>>
> > >>>
> > >>> I see.
> > >>>
> > >>>
> > >>> I was obviously overthinking this :)
> > >>>
> > >>>
> > >>> Sounds good. Will update.
> > >>
> > >> Likely worth putting that into a prior cleanup patch, so there is less noise in
> > >> this patch.
> > >
> > > Well, this is a cleanup specific for smap_gather_stats() funciton, so
> > > I would prefer to keep all the pieces in one place.
> >
> > I meant as part of this series of course.
>
> I understand but this particular patch cleans up smap_gather_stats()
> function, so if would be weird if I move the comment change in that
> function into some other patch. Unless I completely misunderstood your
> suggestion... Maybe you are suggesting to split this condition and
> comment change into a separate patch and making this one a pure
> special-casing elimination?

Ok, after re-reading I think that's what you meant. My first
impression was that you wanted this part to be in one of the previous
cleanup patches. I'll split this into a separate cleanup patch.

>
> >
> > --
> > Cheers,
> >
> > David