Re: [PATCH v2 3/5] proc/task_mmu: remove special-casing of smap_gather_stats() start parameter

[David Hildenbrand (Arm)]

On 9/10/26 18:21, Suren Baghdasaryan wrote:
> On Thu, Sep 10, 2026 at 9:09 AM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>>
>> On Thu, Sep 10, 2026 at 9:01 AM David Hildenbrand (Arm)
>> <david@xxxxxxxxxx> wrote:
>>>
>>>
>>> I meant as part of this series of course.
>>
>> I understand but this particular patch cleans up smap_gather_stats()
>> function, so if would be weird if I move the comment change in that
>> function into some other patch. Unless I completely misunderstood your
>> suggestion... Maybe you are suggesting to split this condition and
>> comment change into a separate patch and making this one a pure
>> special-casing elimination?
> 
> Ok, after re-reading I think that's what you meant. My first
> impression was that you wanted this part to be in one of the previous
> cleanup patches. I'll split this into a separate cleanup patch.

Just to clarify: I'd put all COW mapping changes (using the cow_mapping helper
and rewriting the comment) in one cleanup patch that can argue why it is a
correct cleanup and doesn't introduce a functional change.

-- 
Cheers,

David