Re: [PATCH v4 04/19] crypto: cmh - add SHA-2/SHA-3/SHAKE ahash

[Herbert Xu]

On Tue, Aug 25, 2026 at 03:15:23PM -0700, Alex Ousherovitch wrote:
>
> +/*
> + * .update -- buffer incoming data, submit full blocks to HW.

Please drop block buffering in new drivers.  The Crypto API handles
this for you.  Take a look at the aspeed driver for an example.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt