RE: [PATCH v4 04/19] crypto: cmh - add SHA-2/SHA-3/SHAKE ahash

[Ousherovitch, Alex]

On Fri, Sep 11, 2026 at 02:31:43PM +1000, Herbert Xu wrote:
> Please drop block buffering in new drivers.  The Crypto API handles
> this for you.  Take a look at the aspeed driver for an example.

Done for v5.  The SHA-2/SHA-3/SHAKE, SM3 and cSHAKE ahash drivers now
set CRYPTO_AHASH_ALG_BLOCK_ONLY and let the Crypto API buffer partial
blocks (modelled on drivers/crypto/aspeed).  The hand-rolled holdback
is gone.
Since BLOCK_ONLY's buffering is scatterlist-based, these drivers also
drop CRYPTO_ALG_REQ_VIRT.
cSHAKE stays cra_blocksize 1 as an XOF, so the HC core buffers the
sub-rate remainder across its context save/restore.

Thanks,
Alex