Re: [BUG] WARNING in thaw_super_locked

[Jan Kara]

Hello!

On Fri 11-09-26 08:51:25, Farhad Alemi wrote:
> We are reporting the following crash (reproducer attached):
> Linux version 7.3.0-rc2 50d05c7c76c96b90462f24debacca971d2e86713
> Build Config: UpstreamAppArmorKASAN (KASAN + UBSAN, panic_on_warn=1)

I think this should be fixed by fe967191e585 ("fs: don't return -EINVAL for
successful nested thaw") in 7.3-rc3.

								Honza

> 
> [   50.331769][ T9500] sb->s_writers.freeze_kcount == 0
> [   50.331782][ T9500] WARNING: fs/super.c:2172 at
> thaw_super_locked+0x437/0x960, CPU#1: repro/9500
> [   50.337664][ T9500] Modules linked in:
> [   50.338411][ T9500] CPU: 1 UID: 0 PID: 9500 Comm: repro Not tainted
> 7.3.0-rc2-00099-g50d05c7c76c9 #1 PREEMPT(full)
> [   50.340359][ T9500] Hardware name: QEMU Standard PC (Q35 + ICH9,
> 2009), BIOS 1.17.0-debian-1.17.0-1ubuntu1 04/01/2014
> [   50.342404][ T9500] RIP: 0010:thaw_super_locked+0x437/0x960
> [   50.342962][ T9500] Code: ff 90 0f 0b 90 41 bf ea ff ff ff e9 7f 02
> 00 00 e8 be 5c 7b ff 90 0f 0b 90 41 bf ea ff ff ff e9 6b 02 00 00 e8
> aa 5c 7b ff 90 <0f> 0b 90 41 bf ea ff ff ff e9 57 02 00 00 e8 96 5c 7b
> ff 90 0f 0b
> [   50.344752][ T9500] RSP: 0018:ffffc90008eafa68 EFLAGS: 00010293
> [   50.345341][ T9500] RAX: ffffffff824c3fd6 RBX: ffff88810a876000
> RCX: ffff88802a25cc80
> [   50.346063][ T9500] RDX: 0000000000000000 RSI: 0000000000000000
> RDI: 0000000000000000
> [   50.346777][ T9500] RBP: ffff88810a876378 R08: ffff88810a87608f
> R09: 1ffff1102150ec11
> [   50.347500][ T9500] R10: dffffc0000000000 R11: ffffed102150ec12
> R12: 0000000000000001
> [   50.348223][ T9500] R13: 0000000000000000 R14: ffff88810a87637c
> R15: 0000000000000001
> [   50.348941][ T9500] FS:  00000000028c2400(0000)
> GS:ffff8881da588000(0000) knlGS:0000000000000000
> [   50.349778][ T9500] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   50.350384][ T9500] CR2: 000055c32878aae0 CR3: 000000010adda000
> CR4: 0000000000752ef0
> [   50.351219][ T9500] PKRU: 55555554
> [   50.351570][ T9500] Call Trace:
> [   50.351913][ T9500]  <TASK>
> [   50.352195][ T9500]  filesystems_thaw_callback+0x1b8/0x2f0
> [   50.352713][ T9500]  __iterate_supers+0x2ce/0x420
> [   50.353193][ T9500]  ? __pfx_filesystems_thaw_callback+0x10/0x10
> [   50.353784][ T9500]  ? __pfx___iterate_supers+0x10/0x10
> [   50.354334][ T9500]  ? schedule+0x16e/0x2b0
> [   50.354806][ T9500]  pm_suspend+0x58c/0x760
> [   50.355245][ T9500]  state_store+0x206/0x290
> [   50.355693][ T9500]  ? __pfx_sysfs_kf_write+0x10/0x10
> [   50.356209][ T9500]  kernfs_fop_write_iter+0x3af/0x540
> [   50.356698][ T9500]  vfs_write+0x61d/0xb90
> [   50.357098][ T9500]  ? __pfx_vfs_write+0x10/0x10
> [   50.357544][ T9500]  ? do_sys_openat2+0x14e/0x200
> [   50.357997][ T9500]  ? kmem_cache_free+0x182/0x650
> [   50.358460][ T9500]  ksys_write+0x150/0x270
> [   50.358866][ T9500]  ? __pfx_ksys_write+0x10/0x10
> [   50.359604][ T9500]  do_syscall_64+0x155/0x510
> [   50.360070][ T9500]  ? trace_irq_disable+0x3b/0x140
> [   50.360560][ T9500]  ? entry_SYSCALL_64_after_hwframe+0x77/0x7f
> [   50.361196][ T9500]  ? clear_bhb_loop+0x30/0x80
> [   50.361655][ T9500]  entry_SYSCALL_64_after_hwframe+0x77/0x7f
> [   50.362218][ T9500] RIP: 0033:0x42e806
> [   50.362588][ T9500] Code: 47 ba 04 00 00 00 48 c7 c0 f0 ff ff ff 64
> 89 10 48 c7 c2 ff ff ff ff c9 48 89 d0 c3 0f 1f 84 00 00 00 00 00 48
> 8b 45 10 0f 05 <48> 89 c2 48 3d 00 f0 ff ff 77 0f c9 48 89 d0 c3 66 2e
> 0f 1f 84 00
> [   50.364338][ T9500] RSP: 002b:00007ffec5fbaa00 EFLAGS: 00000202
> ORIG_RAX: 0000000000000001
> [   50.365096][ T9500] RAX: ffffffffffffffda RBX: 0000000000000001
> RCX: 000000000042e806
> [   50.365817][ T9500] RDX: 0000000000000003 RSI: 00000000004880f9
> RDI: 0000000000000004
> [   50.366529][ T9500] RBP: 00007ffec5fbaa10 R08: 0000000000000000
> R09: 0000000000000000
> [   50.367283][ T9500] R10: 0000000000000000 R11: 0000000000000202
> R12: 00007ffec5fbaba8
> [   50.368042][ T9500] R13: 00007ffec5fbabb8 R14: 0000000000000002
> R15: 00000000004af120
> [   50.368775][ T9500]  </TASK>
> [   50.369071][ T9500] Kernel panic - not syncing: kernel: panic_on_warn set ...
> [   50.369727][ T9500] CPU: 1 UID: 0 PID: 9500 Comm: repro Not tainted
> 7.3.0-rc2-00099-g50d05c7c76c9 #1 PREEMPT(full)
> [   50.370770][ T9500] Hardware name: QEMU Standard PC (Q35 + ICH9,
> 2009), BIOS 1.17.0-debian-1.17.0-1ubuntu1 04/01/2014
> [   50.371772][ T9500] Call Trace:
> [   50.372100][ T9500]  <TASK>
> [   50.372373][ T9500]  vpanic+0x56d/0xa60
> [   50.372745][ T9500]  ? __pfx__printk+0x10/0x10
> [   50.373177][ T9500]  ? __pfx_vpanic+0x10/0x10
> [   50.373593][ T9500]  ? is_bpf_text_address+0x292/0x2b0
> [   50.374086][ T9500]  ? is_bpf_text_address+0x26/0x2b0
> [   50.374586][ T9500]  panic+0xc5/0xd0
> [   50.374938][ T9500]  ? __pfx_panic+0x10/0x10
> [   50.375357][ T9500]  __warn+0x315/0x4c0
> [   50.375725][ T9500]  ? thaw_super_locked+0x437/0x960
> [   50.376198][ T9500]  ? thaw_super_locked+0x437/0x960
> [   50.376687][ T9500]  __report_bug+0x273/0x580
> [   50.377135][ T9500]  ? thaw_super_locked+0x437/0x960
> [   50.377628][ T9500]  ? __pfx___report_bug+0x10/0x10
> [   50.378137][ T9500]  ? thaw_super_locked+0x437/0x960
> [   50.378604][ T9500]  report_bug+0x16b/0x220
> [   50.379010][ T9500]  ? thaw_super_locked+0x437/0x960
> [   50.379479][ T9500]  ? thaw_super_locked+0x439/0x960
> [   50.379951][ T9500]  handle_bug+0x9c/0x200
> [   50.380350][ T9500]  exc_invalid_op+0x1a/0x50
> [   50.380870][ T9500]  asm_exc_invalid_op+0x1a/0x20
> [   50.381338][ T9500] RIP: 0010:thaw_super_locked+0x437/0x960
> [   50.381890][ T9500] Code: ff 90 0f 0b 90 41 bf ea ff ff ff e9 7f 02
> 00 00 e8 be 5c 7b ff 90 0f 0b 90 41 bf ea ff ff ff e9 6b 02 00 00 e8
> aa 5c 7b ff 90 <0f> 0b 90 41 bf ea ff ff ff e9 57 02 00 00 e8 96 5c 7b
> ff 90 0f 0b
> [   50.383638][ T9500] RSP: 0018:ffffc90008eafa68 EFLAGS: 00010293
> [   50.384194][ T9500] RAX: ffffffff824c3fd6 RBX: ffff88810a876000
> RCX: ffff88802a25cc80
> [   50.384929][ T9500] RDX: 0000000000000000 RSI: 0000000000000000
> RDI: 0000000000000000
> [   50.385692][ T9500] RBP: ffff88810a876378 R08: ffff88810a87608f
> R09: 1ffff1102150ec11
> [   50.386447][ T9500] R10: dffffc0000000000 R11: ffffed102150ec12
> R12: 0000000000000001
> [   50.387164][ T9500] R13: 0000000000000000 R14: ffff88810a87637c
> R15: 0000000000000001
> [   50.387916][ T9500]  ? thaw_super_locked+0x436/0x960
> [   50.388413][ T9500]  ? thaw_super_locked+0x436/0x960
> [   50.388920][ T9500]  filesystems_thaw_callback+0x1b8/0x2f0
> [   50.389463][ T9500]  __iterate_supers+0x2ce/0x420
> [   50.389916][ T9500]  ? __pfx_filesystems_thaw_callback+0x10/0x10
> [   50.390474][ T9500]  ? __pfx___iterate_supers+0x10/0x10
> [   50.391077][ T9500]  ? schedule+0x16e/0x2b0
> [   50.391503][ T9500]  pm_suspend+0x58c/0x760
> [   50.391933][ T9500]  state_store+0x206/0x290
> [   50.392346][ T9500]  ? __pfx_sysfs_kf_write+0x10/0x10
> [   50.393100][ T9500]  kernfs_fop_write_iter+0x3af/0x540
> [   50.393612][ T9500]  vfs_write+0x61d/0xb90
> [   50.394039][ T9500]  ? __pfx_vfs_write+0x10/0x10
> [   50.394494][ T9500]  ? do_sys_openat2+0x14e/0x200
> [   50.394946][ T9500]  ? kmem_cache_free+0x182/0x650
> [   50.395406][ T9500]  ksys_write+0x150/0x270
> [   50.395808][ T9500]  ? __pfx_ksys_write+0x10/0x10
> [   50.396264][ T9500]  do_syscall_64+0x155/0x510
> [   50.396691][ T9500]  ? trace_irq_disable+0x3b/0x140
> [   50.397157][ T9500]  ? entry_SYSCALL_64_after_hwframe+0x77/0x7f
> [   50.397706][ T9500]  ? clear_bhb_loop+0x30/0x80
> [   50.398141][ T9500]  entry_SYSCALL_64_after_hwframe+0x77/0x7f
> [   50.398702][ T9500] RIP: 0033:0x42e806
> [   50.399085][ T9500] Code: 47 ba 04 00 00 00 48 c7 c0 f0 ff ff ff 64
> 89 10 48 c7 c2 ff ff ff ff c9 48 89 d0 c3 0f 1f 84 00 00 00 00 00 48
> 8b 45 10 0f 05 <48> 89 c2 48 3d 00 f0 ff ff 77 0f c9 48 89 d0 c3 66 2e
> 0f 1f 84 00
> [   50.400946][ T9500] RSP: 002b:00007ffec5fbaa00 EFLAGS: 00000202
> ORIG_RAX: 0000000000000001
> [   50.401732][ T9500] RAX: ffffffffffffffda RBX: 0000000000000001
> RCX: 000000000042e806
> [   50.402465][ T9500] RDX: 0000000000000003 RSI: 00000000004880f9
> RDI: 0000000000000004
> [   50.403178][ T9500] RBP: 00007ffec5fbaa10 R08: 0000000000000000
> R09: 0000000000000000
> [   50.403894][ T9500] R10: 0000000000000000 R11: 0000000000000202
> R12: 00007ffec5fbaba8
> [   50.404618][ T9500] R13: 00007ffec5fbabb8 R14: 0000000000000002
> R15: 00000000004af120
> [   50.405337][ T9500]  </TASK>
> [   50.405933][ T9500] Kernel Offset: disabled
> [   50.406477][ T9500] Rebooting in 86400 seconds..
> 
> Regards,


-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR