Re: [PATCH v2 4/6] iio: accel: adis16201: add ADIS16203 support

[Andy Shevchenko]

On Sun, Sep 13, 2026 at 01:53:05PM +0500, Shehryar Ahmad wrote:
> Add ADIS16203 from staging to mainline ADIS16201. ADIS16203 shares same
> SPI protocol and register addresses. Differing parameters are handled by
> adis16201_chip_info structure.
> 
> ADIS16203 specific support includes DIAG_STAT_SELFTEST_FAIL_BIT, which
> is supported only on ADIS16203, and a separate channel array.
> 
> Kconfig is updated accordingly.

...

>  #define ADIS16201_DIAG_STAT_REG				0x3C
>  #define  ADIS16201_DIAG_STAT_ALARM2			BIT(9)
>  #define  ADIS16201_DIAG_STAT_ALARM1			BIT(8)
> +#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT		5	/* ADIS16203 only */

Two issues with this:
- indentation
- useless comment (we may kinda deduct this from the prefix)

>  #define  ADIS16201_DIAG_STAT_SPI_FAIL_BIT		3
>  #define  ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT		2

...

>  static const struct of_device_id adis16201_of_match[] = {
>  	{ .compatible = "adi,adis16201", .data = &adis16201_chip_data },
> +	{ .compatible = "adi,adis16203", .data = &adis16203_chip_data },
>  	{ },

We want to have the common style for the terminator entries. Perhaps you need
an additional patch to fix that.

>  };
>  

(this blank line included).

...

>  static const struct spi_device_id adis16201_ids[] = {
>  	{ .name = "adis16201", .driver_data = (kernel_ulong_t)&adis16201_chip_data },
> +	{ .name = "adis16203", .driver_data = (kernel_ulong_t)&adis16203_chip_data },
>  	{ },
>  };
>  

Same as per above.

>  module_spi_driver(adis16201_driver);

-- 
With Best Regards,
Andy Shevchenko