Re: [PATCH] iio: adc: at91-sama5d2: disable autosuspend on remove

[Jonathan Cameron]

On Sun, 27 Sep 2026 19:55:19 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Thu, 17 Sep 2026 04:11:28 +0100
> Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> 
> > On Mon, 14 Sep 2026 14:53:39 +0200
> > Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> >   
> > > On Mon, 14 Sep 2026 19:34:22 +0800
> > > Guangshuo Li <lgs201920130244@xxxxxxxxx> wrote:
> > >     
> > > > at91_adc_probe() enables runtime PM autosuspend with
> > > > pm_runtime_use_autosuspend(). The probe error path correctly undoes
> > > > this setting with pm_runtime_dont_use_autosuspend(), but the normal
> > > > remove path only disables runtime PM.
> > > > 
> > > > The runtime PM API requires pm_runtime_use_autosuspend() to be undone
> > > > with pm_runtime_dont_use_autosuspend() at driver exit unless runtime PM
> > > > was enabled with devm_pm_runtime_enable(). Leaving the autosuspend flag
> > > > set therefore leaves the runtime PM state incompletely cleaned up after
> > > > the driver is unbound.
> > > > 
> > > > Add the missing pm_runtime_dont_use_autosuspend() call to the remove
> > > > path.
> > > > 
> > > > This issue was found by manual code inspection.
> > > > 
> > > > Fixes: 75d7556ac0e4 ("iio: adc: at91-sama5d2_adc: add runtime pm support")
> > > > Cc: stable@xxxxxxxxxxxxxxx
> > > > Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> > > > ---
> > > >  drivers/iio/adc/at91-sama5d2_adc.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> > > > index e8a5285bb6d4..e68632e628c7 100644
> > > > --- a/drivers/iio/adc/at91-sama5d2_adc.c
> > > > +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> > > > @@ -2487,6 +2487,7 @@ static void at91_adc_remove(struct platform_device *pdev)
> > > >  
> > > >  	pm_runtime_disable(st->dev);
> > > >  	pm_runtime_set_suspended(st->dev);
> > > > +	pm_runtime_dont_use_autosuspend(st->dev);
> > > >  	clk_disable_unprepare(st->per_clk);
> > > >  
> > > >  	regulator_disable(st->vref);      
> > > 
> > > Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>    
> > Applied.
> > 
> > Please make sure to take into account both Joshua and Krzystof's
> > feedback that multiple near identical changes to drivers in the
> > same subsystem should be in a series.
> >   
> 
> FYI, patches like these will become redundant as I have a patch adding
> this to pm_runtime_reinit() so driver core calls this automatically on
> unbind queued for 7.4 [1].
> 
> [1] https://lore.kernel.org/all/20260919-move-dont-use-autosuspend-v1-1-f6e2d1315c23@xxxxxxxxx/
> 

Nice. Thanks for the heads up.

J