Re: [PATCHv3 0/2] usb: bcma: control VBUS via a regulator
From: Rosen Penev
Date: Sun Sep 27 2026 - 17:10:59 EST
On Thu, Sep 24, 2026 at 11:54 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 25/09/2026 01:38, Rosen Penev wrote:
> > bcma-hcd currently drives the USB power line by grabbing the
> > undocumented "vcc-gpio" property from the controller node and poking
> > it through gpiolib. Besides relying on a non-standard binding, this
> > cannot work on boards such as the NETGEAR R7000 and R8000 where one
> > chipcommon GPIO powers both the USB2 and USB3 cores: the two
> > controllers each request that GPIO exclusively, so the second one
> > fails with -EBUSY and its port stays dead.
> >
> > Instead, switch the driver to the standard regulator interface and
> > express the power rails as regulator-fixed nodes bound to the
> > chipcommon GPIOs. The regulator core reference-counts enable/disable
> > requests, letting both controllers share one GPIO without conflicts.
>
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch -vX` helps here to create proper versioned
> patches. Another useful tool is b4. Skipping the PATCH keyword makes
> filtering of emails more difficult thus making the review process less
> convenient.
I will make this change going forward.
>
> Almost all your patches for months now do everything to escape my filters.
That explains a lot.
>
> Best regards,
> Krzysztof