Re: [PATCH v10 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder
From: Krzysztof Kozlowski
Date: Tue Sep 29 2026 - 02:01:36 EST
On 29/09/2026 07:57, Zhentao Guo wrote:
> Hi Krzysztof,
>> On 29/09/2026 04:59, Zhentao Guo wrote:
>>> Hi Krzysztof,
>>>
>>>> On Thu, Sep 24, 2026 at 03:55:10PM +0800, Zhentao Guo wrote:
>>>>> Add bindings for Amlogic hardware decoder accelerator.
>>>>>
>>>>> Signed-off-by: Zhentao Guo <zhentao.guo@xxxxxxxxxxx>
>>>>> ---
>>>>> .../devicetree/bindings/media/amlogic,s4-vdec.yaml | 114 +++++++++++++++++++++
>>>>> 1 file changed, 114 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..751043c3d9cc
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
>>>>> @@ -0,0 +1,114 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>>> +# Copyright (C) 2025 Amlogic, Inc. All rights reserved
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/media/amlogic,s4-vdec.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: Amlogic Video Decode Accelerator
>>>>> +
>>>>> +maintainers:
>>>>> + - Zhentao Guo <zhentao.guo@xxxxxxxxxxx>
>>>>> +
>>>>> +description:
>>>>> + The Video Decoder Accelerator present on Amlogic SOCs.
>>>>> + It supports stateless h264 decoding.
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + const: amlogic,s4-vdec
>>>>> +
>>>>> + reg:
>>>>> + minItems: 2
>>>> What is happening here? Previous version was different.
>>> maxItems: 2 implies that a single items is also allowed,but the hardware actually requires at least two register regions (dos
>> Since when?
> It should have been minItems:2 ever since v1,I must admit that this is a
> long-standing mistake.
No. Since when 1 item is allowed?
Best regards,
Krzysztof