Re: [PATCH net-next v2 0/3] selftests: drv-net: Introduce flow-control selftest

[Jakub Kicinski]

On Fri, 25 Sep 2026 20:26:24 +0200 Maxime Chevallier (Netdev
Foundation) wrote:
> This is V2 for the ethtool flow control test.
> 
> This test aims at validating the flow control implementation in drivers,
> using the ethtool API.

Still does not look like our other tests but good enough, I guess.

One note on patch 1:

        wait_file(f"/sys/class/net/{self.dev['ifname']}/carrier",
                  lambda x: x.strip() == "1")

is a shorter way of waiting for link.

Other than that looks like pylint has a couple of nit picks

tools/testing/selftests/drivers/net/hw/pause.py:1:0: C0302: Too many lines in module (1035/1000) (too-many-lines)

tools/testing/selftests/drivers/net/hw/pause.py:1020:0: C0116: Missing function or method docstring (missing-function-docstring)

.. and we'll need Andrew's review.
-- 
pw-bot: cr