Re: [PATCH v2 2/8] irqchip/al-fic: use %pOF and raise init log level

[Radu Rendec]

On Sun, 2026-09-27 at 08:06 +0000, Eliav Farber wrote:
> Use %pOF in the driver's log messages, so that both the success and the
> error paths identify the specific FIC instance by its full devicetree
> path rather than by its bare node name, e.g.:
> 
>   /soc/interrupt-controller@fd803000 initialized successfully in Legacy mode (parent-irq=3)
> 
> A single controller is described by several FIC nodes that share the same
> bare node name (e.g. "interrupt-controller"), so the bare name cannot tell
> one instance from another. The full path includes the unit address and
> keeps the instances distinguishable.
> 
> While converting the parent-missing message, fix a grammar typo in it
> ("device require a parent" -> "device requires a parent").
> 
> Raise the successful-initialization message from pr_debug to pr_info, as
> this single boot-time printout is useful when dynamic debug is not enabled
> at this stage of boot.
> 
> Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
> ---
> v2: reworded to explain why %pOF matters (several nodes of one controller
>     share the same bare node name, so only the full path with the unit
>     address distinguishes them). Also switched from full_name string to
>     %pOF. No functional change from v1's "use full node name" patch beyond
>     the log level and the grammar fix.
> 
>  drivers/irqchip/irq-al-fic.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-al-fic.c b/drivers/irqchip/irq-al-fic.c
> index 35581332b40e..760bd08dcff4 100644
> --- a/drivers/irqchip/irq-al-fic.c
> +++ b/drivers/irqchip/irq-al-fic.c
> @@ -216,8 +216,8 @@ static struct al_fic *al_fic_wire_init(struct device_node *node,
>  		goto err_free;
>  	}
>  
> -	pr_debug("%s initialized successfully in Legacy mode (parent-irq=%u)\n",
> -		 fic->name, parent_irq);
> +	pr_info("%pOF initialized successfully in Legacy mode (parent-irq=%u)\n",
> +		node, parent_irq);
>  
>  	return fic;
>  
> @@ -235,20 +235,19 @@ static int __init al_fic_init_dt(struct device_node *node,
>  	struct al_fic *fic;
>  
>  	if (!parent) {
> -		pr_err("%s: unsupported - device require a parent\n",
> -		       node->name);
> +		pr_err("%pOF: unsupported - device requires a parent\n", node);
>  		return -EINVAL;
>  	}
>  
>  	base = of_iomap(node, 0);
>  	if (!base) {
> -		pr_err("%s: fail to map memory\n", node->name);
> +		pr_err("%pOF: fail to map memory\n", node);
>  		return -ENOMEM;
>  	}
>  
>  	parent_irq = irq_of_parse_and_map(node, 0);
>  	if (!parent_irq) {
> -		pr_err("%s: fail to map irq\n", node->name);
> +		pr_err("%pOF: fail to map irq\n", node);
>  		ret = -EINVAL;
>  		goto err_unmap;
>  	}
> @@ -258,9 +257,8 @@ static int __init al_fic_init_dt(struct device_node *node,
>  			       node->name,
>  			       parent_irq);
>  	if (IS_ERR(fic)) {
> -		pr_err("%s: fail to initialize irqchip (%lu)\n",
> -		       node->name,
> -		       PTR_ERR(fic));
> +		pr_err("%pOF: fail to initialize irqchip (%lu)\n",
> +		       node, PTR_ERR(fic));
>  		ret = PTR_ERR(fic);
>  		goto err_irq_dispose;
>  	}

Reviewed-by: Radu Rendec <radu@xxxxxxxxxx>