Re: [PATCH 4/5] dt-bindings: iio: dac: adi,ad5758: Fix the 4 mA to 20 mA current range

[Jonathan Cameron]

On Mon, 28 Sep 2026 14:34:49 -0500
Rob Herring <robh@xxxxxxxxxx> wrote:

> On Sun, Sep 20, 2026 at 07:39:49PM +0100, Jonathan Cameron wrote:
> > On Fri, 18 Sep 2026 21:20:31 +0900
> > Arka Mondal <arka@xxxxxxxxxxxxxx> wrote:
> >   
> > > adi,range-microamp gives the 4 mA to 20 mA range as <4 24000>. The
> > > values are in microamps, so this reads as 4 uA to 24 mA. The original
> > > text binding described <4 24000> as the "4 mA to 20 mA current range",
> > > and the data sheet (Rev. B, Table 32) confirms range code 1010 is
> > > 4 mA to 20 mA.
> > > 
> > > Add <4000 20000> and mark <4 24000> deprecated, so existing device
> > > trees still validate.
> > > 
> > > Fixes: 777baca07ef1 ("dt-bindings: iio: dac: Add docs for AD5758 DAC")
> > > Signed-off-by: Arka Mondal <arka@xxxxxxxxxxxxxx>  
> > 
> > DT reviewers.   Better to paper over a dt that is specifying the wrong
> > range as this does (deprecated) or just make it obvious by failing
> > the binding checks?  I'm thinking failing is better as gets any such
> > dt fixed up faster.  I also suspect no one actually it this because the
> > disconnect they should have seen when reading the datasheet and considering
> > what they wanted should have meant they saw this bug!  
> 
> No in tree .dts (for which I don't want more warnings), so I would just 
> drop it.

Works for me. Arka, please send v2 of patches 4 and 5 rebased on my togreg branch.
Only change being to drop the broken parameter both from binding and from the
driver.  If anyone screams driver side we might paper over this, but they really
should have noticed the value was garbage when they wrote their DT!

Jonathan


> 
> Rob