Re: [PATCH v7 06/13] nvme-pci: implement dma-buf backed requests

[Christoph Hellwig]

On Tue, Sep 29, 2026 at 05:45:39PM +0200, Christophe JAILLET wrote:
>> @@ -27,6 +27,8 @@
>>   #include <linux/io-64-nonatomic-lo-hi.h>
>>   #include <linux/io-64-nonatomic-hi-lo.h>
>>   #include <linux/sed-opal.h>
>> +#include <linux/dma-buf-io.h>
>> +#include <linux/dma-resv.h>
>
> Move up, to keep better alphabetical order ?

Doesn't really matter.

>>   +struct nvme_dmabuf_map {
>> +	struct dma_buf_io_map base;
>> +	struct sg_table *sgt;
>> +	unsigned nr_entries;
>> +	dma_addr_t dma_list[];
>
> Add __counted_by(nr_entries) and update nvme_dma_buf_io_map() so that 
> nr_entries is set at the right time ?

Yeah, that would be useful.