Re: [PATCH v6 11/31] ext4: implement buffered read path using iomap

[Theodore Tso]

I tried running "git am" on your patch series, and after resolving a
patch conflict manually, I ran a build check to make sure things were
still building, and I ran into a couple of issues that caused the
build to fail:

On Thu, Sep 03, 2026 at 08:35:23PM -0500, Zhang Yi wrote:
> +static DEFINE_IOMAP_ITER_NEXT(ext4_iomap_buffered_read_next,
> +			      ext4_iomap_buffered_read_begin);

/usr/projects/linux/ext4/fs/ext4/inode.c:4016:8: error: type defaults to ‘int’ in declaration of ‘DEFINE_IOMAP_ITER_NEXT’ [-Wimplicit-int]
 4016 | static DEFINE_IOMAP_ITER_NEXT(ext4_iomap_buffered_read_next,
       |        ^~~~~~~~~~~~~~~~~~~~~~
       /usr/projects/linux/ext4/fs/ext4/inode.c:4017:31: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
        4017 |                               ext4_iomap_buffered_read_begin);
	      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

> +
> +const struct iomap_ops ext4_iomap_buffered_read_ops = {
> +	.iomap_next = ext4_iomap_buffered_read_next,
> +};

/usr/projects/linux/ext4/fs/ext4/inode.c:4020:10: error: ‘const struct iomap_ops’ has no member named ‘iomap_next’; did you mean ‘iomap_end’?
 4020 |         .iomap_next = ext4_iomap_buffered_read_next,
      |          ^~~~~~~~~~
      |          iomap_end
/usr/projects/linux/ext4/fs/ext4/inode.c:4020:23: error: ‘ext4_iomap_buffered_read_next’ undeclared here (not in a function); did you mean ‘ext4_iomap_buffered_read_ops’?
 4020 |         .iomap_next = ext4_iomap_buffered_read_next,
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                       ext4_iomap_buffered_read_ops

I'm going to assume these issues got resolved later in the patch set,
but I wanted to point this out since this can make it harder to bisect
the kernel in the future.

Thanks,

						- Ted