Re: [PATCH v2 0/2] x86/vdso: Replace deprecated simple_strtoul() with kstrtouint()

[Thorsten Blum]

On Mon, Oct 05, 2026 at 04:33:37PM +0000, Habil Eren Türker wrote:
> This patch series replaces the deprecated simple_strtoul() function
> with the safer kstrtouint() variant in the x86 vdso setup code.
> 
> The simple_strtoul() function is deprecated as it silently ignores
> overflows. Proper bounds and lineer error checking are introduced.
> 
> Changes in v2:
> - Fixed the logical short-circuit operator bug in parsing error paths
>   where invalid inputs could trigger deceptive warning logs.
> - Refactored error handling into a linear flow with unlikely() macros
>   to avoid branch misprediction.
>  
> Habil Eren Türker (2):
>   x86/vdso: Replace deprecated simple_strtoul() with kstrtouint()
>   x86/vdso: Replace deprecated simple_strtoul() with kstrtouint() in
>     vdso_setup
> 
>  arch/x86/entry/vdso/vdso32-setup.c | 11 +++++++++--
>  arch/x86/entry/vdso/vma.c          | 15 ++++++++++++++-
>  2 files changed, 23 insertions(+), 3 deletions(-)

I submitted a very similar series a while ago [1], but haven't received
feedback yet (besides a Reviewed-by from Randy on the documentation
change).

Dave, did you have a chance to take a look at my series yet?

Thanks,
Thorsten

[1] https://lore.kernel.org/lkml/20260831101657.2947-5-blum@xxxxxxxxxx/