Re: [PATCH v2 14/15] PCI: rcar-gen4: Route Root Port PME and bandwidth notifications

[Koichiro Den]

On Sun, Oct 04, 2026 at 06:40:20AM +0200, Marek Vasut wrote:
> On 9/28/26 6:52 PM, Koichiro Den wrote:
> 
> [...]
> 
> > @@ -753,12 +766,12 @@ static irqreturn_t rcar_gen4_pcie_msi_irq_handler(int irq, void *data)
> >   	status = readl(rcar->base + PCIEINTSTS0) &
> >   		 readl(rcar->base + PCIEINTSTS0EN);
> > -	if (!(status & MSI_CTRL_INT))
> > -		return IRQ_NONE;
> > +	if (status & MSI_CTRL_INT)
> > +		dw_handle_msi_irq(&rcar->dw.pp);
> > +	if (status & RP_SUB_MASK)
> > +		rcar_gen4_pcie_rp_irq_dispatch(rcar);
> > -	dw_handle_msi_irq(&rcar->dw.pp);
> > -
> > -	return IRQ_HANDLED;
> > +	return status & (MSI_CTRL_INT | RP_SUB_MASK) ? IRQ_HANDLED : IRQ_NONE;
> 
> Only a small nitpick, please don't use the ternary operator, readability
> suffers, please do:
> 
> "
> if (status & (MSI_CTRL_INT | RP_SUB_MASK))
>   return IRQ_HANDLED;
> 
> return IRQ_NONE;
> "

Will update in v3. Thanks for the review!

Best regards,
Koichiro Den

> 
> with that fixed,
> 
> Reviewed-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> 
> Thank you !