Re: [PATCH v11 0/2] phy: rockchip: naneng-combphy: add SGMII MAC selection for RK3568
From: Rob Herring
Date: Mon Oct 05 2026 - 23:27:23 EST
On Tue, Oct 06, 2026 at 06:59:42AM +0800, Coia Prant wrote:
> Changes since v10:
>
> - Drop the top-level "default: 1" for "rockchip,sgmii-mac-sel".
> dtschema injects top-level defaults into every matching node, and the
> injected value conflicts with the "else" branch that forbids the
> property on non-RK3568 variants, breaking dtbs_check on those
> platforms. The driver already treats an absent property as 1 (GMAC1),
> so behavior is unchanged.
What? That's not right. 'default' has no effect on the validation.
Please add it back. If the property doesn't apply to some variant, then
default doesn't matter.
Rob