Re: [PATCH v11 0/2] phy: rockchip: naneng-combphy: add SGMII MAC selection for RK3568

[Coia Prant]

Rob Herring <robh@xxxxxxxxxx> 于2026年10月6日周二 11:27写道：
>
> On Tue, Oct 06, 2026 at 06:59:42AM +0800, Coia Prant wrote:
> > Changes since v10:
> >
> > - Drop the top-level "default: 1" for "rockchip,sgmii-mac-sel".
> >   dtschema injects top-level defaults into every matching node, and the
> >   injected value conflicts with the "else" branch that forbids the
> >   property on non-RK3568 variants, breaking dtbs_check on those
> >   platforms. The driver already treats an absent property as 1 (GMAC1),
> >   so behavior is unchanged.
>
> What? That's not right. 'default' has no effect on the validation.
> Please add it back. If the property doesn't apply to some variant, then
> default doesn't matter.
>
> Rob

Hi Rob,

Thanks for the correction. You're right, 'default' has no effect on
validation. I'll add it back and send a v12 right away.

Sorry for the noise.

Coia