Re: [EXTERNAL] Re: [PATCH 1/2] drm/imagination: Switch to kernel-style MMU defines and access

[Alexandru Dadu]

On Sat, 2026-10-03 at 19:55 +0900, Gyeyoung Baek wrote:
> *** CAUTION: This email originates from a source not known to
> Imagination Technologies. Think before you click a link or open an
> attachment ***
> 
> Hi Alexandru,
> 
> > 
> >  /**
> > @@ -442,18 +424,18 @@ pvr_page_table_l2_entry_raw_is_valid(struct
> > pvr_page_table_l2_entry_raw entry)
> >   *                        associated with @entry.
> >   *
> >   * When calling this function, @child_table_dma_addr must be a
> > valid DMA
> > - * address and a multiple of
> > %ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGNSIZE.
> > + * address and a multiple of %ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGN.
> >   */
> 
> nit: ALIGN is now a shift, so "a multiple of" in this comment no
> longer fits.

Hi Gyeyoung,

Thank you for the review!
Regarding the nit remark, ALIGNSIZE was also a shift before changing it
to ALIGN.

> 
> Reviewed-by: Gyeyoung Baek <gye976@xxxxxxxxx>
> 
Thanks,
Alexandru Dadu