Re: [EXTERNAL] Re: [PATCH 1/2] drm/imagination: Switch to kernel-style MMU defines and access

[Gyeyoung Baek]

Hi Alexandru,

> > >
> > >  /**
> > > @@ -442,18 +424,18 @@ pvr_page_table_l2_entry_raw_is_valid(struct
> > > pvr_page_table_l2_entry_raw entry)
> > >   *                        associated with @entry.
> > >   *
> > >   * When calling this function, @child_table_dma_addr must be a
> > > valid DMA
> > > - * address and a multiple of
> > > %ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGNSIZE.
> > > + * address and a multiple of %ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGN.
> > >   */
> >
> > nit: ALIGN is now a shift, so "a multiple of" in this comment no
> > longer fits.
>
> Hi Gyeyoung,
>
> Thank you for the review!
> Regarding the nit remark, ALIGNSIZE was also a shift before changing it
> to ALIGN.
>

I think ALIGNSIZE was the size rather than the shift:

  -#define ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGNSHIFT (12U)
  -#define ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGNSIZE (4096U)
  +#define ROGUE_MMUCTRL_PC_DATA_PD_BASE_ALIGN 12

so the comment now reads as "a multiple of 12" (Only a nit though).

-- 
Thanks,
Gyeyoung