回覆: [PATCH net-next v2 4/6] net: ftgmac100: Require phy-mode for AST2700

[Jacky Chou]

Hi Andrew,

Thank you for your review.

> > The driver currently defaults to RGMII when the "phy-mode" property is
> > missing from the device tree. This default is no longer valid for
> > AST2700, which also supports RMII via FTGMAC100_QUIRK_RMII_ENABLE.
> >
> > Make "phy-mode" a required property for AST2700 and fail probe with an
> > error message if it is not specified, instead of silently defaulting
> > to RGMII.
> 
> You need to update the DT binding, mark it as required for ast2700.
> 

I will update the dt-binding patch in next version.

Thanks,
Jacky