Re: [PATCH] clocksource/drivers/pistachio: fix leaked iomap on error paths

[Krzysztof Kozlowski]

On Fri, 09 Oct 2026 00:02:43 +0800, Haotian Zhang wrote:
> pistachio_clksrc_of_init() maps the timer registers with of_iomap() and
> stores the result in the static global pcs_gpt.base, but every error path
> after the mapping (syscon lookup, regmap_update_bits, the two
> of_clk_get_by_name() calls and both clk_prepare_enable() calls) returns
> without calling iounmap(), leaking the mapping.
> 
> Route all these error paths through a common err_unmap label that calls
> iounmap() and clears pcs_gpt.base.
> 
> Fixes: 84583983c319 ("CLOCKSOURCE: Add Pistachio clocksource-only driver")
> Assisted-by: DeepSeek-V4.1-Flash
> Signed-off-by: Haotian Zhang <vulab@xxxxxxxxxxx>
> ---
>  drivers/clocksource/timer-pistachio.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)
> 



Multiple things here:
1. Your team ignored completely previous feedback.

2. You use multiple identities with this email, thus I actually doubt we speak
   with actual person.

3. Finally, same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document usage of LLM and how what you should not do
if this was posted in a good faith.

Best regards,
Krzysztof