Re: [PATCH net 1/2] sfc: ptp: serialize host and MC synchronization transactions

[Edward Cree]

On 09/10/2026 19:32, Alex Austin wrote:
> Protect the DMA handshake and result processing against concurrent
> synchronization callers. Serialize clock adjustments with the same mutex
> so they cannot change the PHC during a capture.
> 
> Fixes: 7c236c43b838 ("sfc: Add support for IEEE-1588 PTP")
> Signed-off-by: Alex Austin <alex.austin@xxxxxxx>
> Reviewed-by: Alejandro Lucero <alucerop@xxxxxxx>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@xxxxxxx>
...
>  static int efx_phc_settime(struct ptp_clock_info *ptp,
>  			   const struct timespec64 *e_ts)
>  {
> -	/* Get the current NIC time, efx_phc_gettime.
> -	 * Subtract from the desired time to get the offset
> -	 * call efx_phc_adjtime with the offset
> -	 */

Not immediately clear why this comment is getting disappeared; it appears
 to still be accurate.  Is it just thought superfluous?

-ed