Re: [PATCH 2/3] arm64: dts: qcom: Consolidate Glymur CoB power grid
From: Abel Vesa
Date: Thu Oct 29 2026 - 04:53:50 EST
On 26-10-28 21:04:25, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> The power grid is partly defined by connections to the on-SoC
> peripherals, which (due to various reasons, electrical and practical)
> are well-defined for each PMIC configuration. Factor out the common
> bits for Glymur CoB devices.
>
> Because some DTs (mostly the CRD) disagreed about certain values, I
> made sure to look up the desired one for each of these common rails,
> they are now set as expected.
>
> This enables one to take care of most required vreg settings with a
> single #include.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
With the concerns from sashiko addressed, this looks good to me, so:
Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>