Re: [PATCH] drm/i915/gem: Reset err for each fence entry

[Andi Shyti]

Hi Joonas,

On Thu, Oct 29, 2026 at 09:36:05AM +0100, Andi Shyti wrote:
> Hi Joonas,
> 
> On Thu, Oct 29, 2026 at 09:31:50AM +0200, Joonas Lahtinen wrote:
> > Quoting Andi Shyti (2026-10-28 13:39:14)
> > > Hi Lu,
> > > 
> > > On Tue, Oct 27, 2026 at 03:28:32PM +0800, yaolu@xxxxxxxxxx wrote:
> > > > From: Lu Yao <yaolu@xxxxxxxxxx>
> > > > 
> > > > If dma_fence_chain_find_seqno() failed once, 'err' will store val in
> > > > the following loop. May causing returns '-EINVAL' even though that
> > > > entry never called dma_fence_chain_find_seqno() at all.
> > > > 
> > > > Fixes: 13149e8bafc4 ("drm/i915: add syncobj timeline support")
> > > > Signed-off-by: Lu Yao <yaolu@xxxxxxxxxx>
> > > 
> > > pushed to drm-intel-gt-next.
> > 
> > This was pushed without any R-b, DIM should have given you a warning
> > when applying the patch.
> 
> I forgot to add it, or rather, I remembered it too late. Since
> it's a simple and straightforward patch (most likely LLM
> generated), I didn't want to make a fuss about it.
> 
> > I've reverted it for now, please use DIM and check the warnings before
> > merging stuff.
> 
> I used dim and apparently dim is not enforcing it.
> 
> I'll push it again with my r-b.

Now it's pushed with my r-b.

Thanks, Joonas for looking into this.

Andi