Re: [PATCH v6 04/18] dt-bindings: soc: starfive: Add starfive,jh7110-hdmi-subsystem

[Rob Herring]

On Thu, Oct 29, 2026 at 06:53:25PM +0100, Michal Wilczynski wrote:
> 
> 
> On 10/29/26 18:38, Rob Herring (Arm) wrote:
> > 
> > On Thu, 29 Oct 2026 08:53:38 +0100, Michal Wilczynski wrote:
> >> Add the dt-binding for the StarFive JH7110 HDMI subsystem.
> >>
> >> The JH7110 HDMI IP is a monolithic block containing both the digital
> >> controller and analog PHY in a single register space. This binding
> >> defines the parent device, which holds the shared register map, and its
> >> two children: the PHY and the controller.
> >>
> >> The two have separate resources. The PHY takes the 24 MHz reference
> >> clock and provides both the pixel clock, which the VOUT clock generator
> >> routes on to the display controller, and the phy the controller uses.
> >> The controller takes its clocks from the VOUT clock generator. What
> >> they share is the register space, which the parent maps.
> >>
> >> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> >> Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
> >> ---
> >>  .../starfive/starfive,jh7110-hdmi-subsystem.yaml   | 95 ++++++++++++++++++++++
> >>  1 file changed, 95 insertions(+)
> >>
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.yaml: Unresolvable reference: /schemas/phy/starfive,jh7110-inno-hdmi-phy.yaml#
> > Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.example.dtb: hdmi@29590000 (starfive,jh7110-hdmi-subsystem): phy: False schema does not allow {'compatible': ['starfive,jh7110-inno-hdmi-phy'], '#clock-cells': 0, 'clocks': [[4294967295]], '#phy-cells': 0, 'phandle': 2}
> > 	from schema $id: https://protect2.fireeye.com/v1/url?k=e93a78e1-88b16dd1-e93bf3ae-000babffaa23-e7f80dd3ed8ff65f&q=1&e=27d4095f-5012-49f1-94e3-a63fd9693348&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fstarfive%2Fstarfive%2Cjh7110-hdmi-subsystem.yaml
> > Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-hdmi-subsystem.example.dtb: /example-0/soc/hdmi@29590000/phy: failed to match any schema with compatible: ['starfive,jh7110-inno-hdmi-phy']
> > 
> 
> This patch depends on the JH7110 HDMI PHY series which adds
> starfive,jh7110-inno-hdmi-phy.yaml [1].

I'm aware. I just want whomever applies this to know they need to wait 
for that series.

> With that series applied dt_binding_check is clean.

Humm, this is applied with b4 and you added the dependencies for 
it (thanks!), so it should have run with that series applied too. I'll 
have to investigate.

Rob