Re: [PATCH v5] KEYS: key_garbage_collector(): process in chunks
From: Jarkko Sakkinen
Date: Thu Oct 29 2026 - 20:17:39 EST
On Fri, Oct 30, 2026 at 07:41:48AM +0800, Hillf Danton wrote:
> On Thu, 29 Oct 2026 19:29:17 +0200 Jarkko Sakkinen wrote:
> > key_garbage_collector() has a design that is not resistant enough for
> > workqueue lockups. The duration scales up relative to the number of items
> > in the serial tree, which causes a reoccuring theme of being guilty of
> > causing workqueue lockups.
> >
> Given cond_resched() the gc work is not a cpu hog, and given concurrency
> workqueue can get individual cpu highly overloaded in short time, so what
> you delivered is a half backed croissant, HBC, as you failed to make it
> clear why lockup occurs when the number of gc items rockets up.
Please, read:
1. Documentation/process/code-of-conduct-interpretation.rst
2. Documentation/process/code-of-conduct.rst
Br, Jarkko