Re: [PATCH net-next v2] netdevsim: reject port addition and clean up ports after a failed reload

[Mina Almasry]

On Thu, Oct 29, 2026 at 5:15 PM Ömer Mete Kaya <omermetekaya0@xxxxxxxxx> wrote:
>
> nsim_drv_port_add() does not check devlink_is_reload_failed(), so ports
> can be added via new_port after a failed reload.  nsim_dev_reload_destroy()
> returns early in that state, leaving them behind.  nsim_drv_remove() then
> hits WARN_ON in bpf_offload_dev_destroy() and a subsequent use-after-free.
>
> Block port creation with -EIO when reload has failed, and delete any
> leftover ports on the early-return path as a safety net.
>
> Fixes: 75ba029f3c07 ("netdevsim: implement proper devlink reload")
> Reported-by: syzbot+88435e204734072bf39a@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=88435e204734072bf39a
> Signed-off-by: Ömer Mete Kaya <omermetekaya0@xxxxxxxxx>

I'm so sorry, I don't think I was clear. Currently net-next is closed.
I should have said wait until net-next re-opens and THEN send your
fix:

https://netdev.bots.linux.dev/net-next.html

And yes, normally fixes go to net, but the volume of fixes has been so
large that non-critcal fixes now go to net-next.

Let me try this:

pw-bot: defer


-- 
Thanks,
Mina