Re: [PATCH 3/3] drm/panel: raydium-rm68200: Use multi-context helpers for init sequence

[Doug Anderson]

Hi,

On Wed, Oct 14, 2026 at 6:50 AM Hsieh Hung-En <hungen3108@xxxxxxxxx> wrote:
>
> Replace the custom DCS write helpers with mipi_dsi_dcs_write_seq_multi()
> and mipi_dsi_dcs_write_var_seq_multi(), preserving individual DCS
> transactions for registers that do not support auto-increment.
>
> Previously, initialization failures were only logged, allowing prepare()
> to report success despite incomplete initialization. Share the
> multi-context with prepare() so that after the first failed write,
> subsequent DCS commands and delays are skipped, and the error is
> propagated to prepare().
>
> The new helpers log errors without rate limiting.
>
> Signed-off-by: Hsieh Hung-En <hungen3108@xxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-raydium-rm68200.c | 184 ++++++++----------
>  1 file changed, 80 insertions(+), 104 deletions(-)

This patch looks good to me.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

It would also be nice to change the uppercase hex numbers (like 0xAB)
to lowercase (0xab), since Linux convension says they should be
lowercase. I wouldn't object to a v2 fixing that, but I won't insist.

To answer your question in the cover letter:

> Doug, do you think this fail-fast behavior is appropriate here, or
> would you prefer to preserve the existing best-effort initialization?

Yes, what you've done here is correct, in my opinion.