Re: [PATCH 1/3] drm/panel: feiyang-fy07024di26a30d: Use mipi_dsi_*_multi() functions

[Doug Anderson]

Hi,

On Wed, Oct 14, 2026 at 6:50 AM Hsieh Hung-En <hungen3108@xxxxxxxxx> wrote:
>
> @@ -81,44 +81,51 @@ static int feiyang_prepare(struct drm_panel *panel)
>                 const struct feiyang_init_cmd *cmd =
>                                                 &feiyang_init_cmds[i];
>
> -               ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data,
> +               mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, cmd->data,
>                                                 FEIYANG_INIT_CMD_LEN);
> -               if (ret < 0)
> -                       return ret;

I won't block landing the patch for it (though I woulnd't mind a v2
fixing it either), but we also should get rid of the
"feiyang_init_cmds" data structure. Instead, just hardcode 7 calls to
mipi_dsi_dcs_write_buffer_multi() with the 7 initialization commands.
If you search the past multi-conversion patches on the mailing lists
you can find some references for doing this on other panels. Let me
know if you can't find it.

This could land as-is, or I could re-review a v2 that inlines the 7
commands. Up to you.


>         }
>
> -       return 0;
> +       return dsi_ctx.accum_err;

There's a pre-existing issue here that I also won't block landing for,
but again I'd love to see it addressed in a v2. If we return an error
here, we should probably turn off the regulators and the GPIO. Many
other panels handle this correctly, so you can follow those examples.


Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

If there are no additional comments, I'll probably land in ~1 week.