Re: [PATCH 05/21] ASoC: SOF: Intel: hda-sdw-bpt: Stop active DMA before closing BPT streams

[Lee Jones]

On Fri, 30 Oct 2026, Vinod Koul wrote:

> On 30-10-26, 11:14, Mark Brown wrote:
> > On Fri, Oct 30, 2026 at 10:46:44AM +0000, Lee Jones wrote:
> > > When sdw_enable_stream() fails in intel_ace2x_bpt_send_async() after
> > > hda_sdw_bpt_send_async() has already started the TX and RX DMA streams,
> > > intel_ace2x_bpt_close_stream() invokes hda_sdw_bpt_close() directly
> > > without calling hda_sdw_bpt_wait().  As a result,
> > > hda_sdw_bpt_dma_deprepare() tears down the DMA buffers and BDL while
> > > the DMA hardware is still running.
> > 
> > Does this actually need to be in with all the Soundwire stuff?  There's
> > no immediately obvious dependency.
> 
> Doesnt seem dependent to me

Sashiko grouped this report under the SoundWire subsystem because the
caller (intel_ace2x_bpt_close_stream()) lives in
drivers/soundwire/intel_ace2x.c, even though hda_sdw_bpt_close() itself
is under sound/soc/sof/intel/.

You're both right, there is no dependency on the rest of the series.

Happy for you to take it directly through ASoC if the patch looks good
to you or I can drop it from v2 of the SoundWire set and send it
standalone or when I handle ASoC.

-- 
Lee Jones