Re: [PATCH v11 07/18] HID: asus: add support for response curve

[Ilpo Järvinen]

On Fri, 30 Oct 2026, Denis Benato wrote:

> 
> On 10/26/26 14:06, Ilpo Järvinen wrote:
> > On Sun, 25 Oct 2026, Denis Benato wrote:
> >
> >> ROG ally devices allows configuring the response curve of both joysticks,
> >> therefore add the ability of userspace to modify the response curve by
> >> exposing relevant sysfs attributes.
> >>
> >> Signed-off-by: Denis Benato <denis.benato@xxxxxxxxx>
> >> Signed-off-by: Luke Jones <luke@xxxxxxxxxx>
> >> ---
> >>  drivers/hid/hid-asus.c | 297 ++++++++++++++++++++++++++++++++++++++++-
> >>  1 file changed, 294 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> >> index b4bc89ec28bc..e1883ee20413 100644
> >> --- a/drivers/hid/hid-asus.c
> >> +++ b/drivers/hid/hid-asus.c
> >> @@ -22,6 +22,7 @@
> >>  
> >>  #include <linux/acpi.h>
> >>  #include <linux/cleanup.h>
> >> +#include <linux/ctype.h>
> >>  #include <linux/device.h>
> >>  #include <linux/dmi.h>
> >>  #include <linux/hid.h>
> >> @@ -185,6 +186,18 @@ struct asus_touchpad_info {
> >>  	int report_size;
> >>  };
> >>  
> >> +struct ally_joystick_resp_curve_param {
> >> +	u8 move;
> >> +	u8 resp;
> >> +} __packed;
> > Add include (if I didn't mentioned it already with some earlier patch,
> > I don't recall anymore :-)).
> 
> Which one? I only see drivers either not including it directly or highly hardware-coupled including the one
> for the architecture, what about a driver that must work for x86 and arm64?

__packed comes through linux/compiler.h

It's actually in include/linux/compiler_attributes.h but I assume we can 
rely on compiler.h including it for the foreseable future (guaranteed 
indirect include path).

-- 
 i.