Re: [PATCH 3/3] arm64: dts: qcom: glymur: Add EC thermal zones

[Manaf Meethalavalappu Pallikunhi]

Hi Konrad,

On 10/29/2026 2:38 PM, Anvesh Jain P wrote:
> On 10/20/2026 1:33 PM, Konrad Dybcio wrote:
> > > Add support for back cover, keyboard, and SoC thermal zones through
> > > temperature sensors hosted on the EC for Glymur and Mahua CRDs.
> > >
> > > Signed-off-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 45 +++++++++++++++++++++++++++++++-
> > >   1 file changed, 44 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> > > index e27c697e3170..571c98124a40 100644
> > > --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> > > @@ -594,10 +594,12 @@ &i2c9 {
> > >   
> > >   	status = "okay";
> > >   
> > > -	embedded-controller@76 {
> > > +	ec: embedded-controller@76 {
> > "ec" is a super short label, perhaps let's spell out
> > embedded_controller
>
> Thanks for you review, I will rename the label to embedded_controller.
> > [...]
> >
> > > +&thermal_zones {
> > > +	ec-back-cover {
> > > +		polling-delay = <10000>;
> > > +		thermal-sensors = <&ec 2>;
> > > +
> > > +		trips {
> > > +			trip-point0 {
> > > +				temperature = <90000>;
> > This is *really* hot!
>
> The 90°C trip value was suggested by thermal team(Manaf Meethalavalappu
> Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>). We are open to using a
> lower value if this is too high for the keyboard and back-cover sensors.

These sensors are intended to be controlled primarily from userspace by 
the thermal governor in thermald, through the powercap sysfs interface 
[1]. We do not plan to add cooling bindings for these thermal zones.

Based on discussions with the tuning team, we agreed on a hot-trip 
threshold of 90°C for these sensors.

[1] 
https://github.com/intel/thermal_daemon/pull/614/commits/7f3dd62353e039957e52eeb40c67ec388d543ebe

Thanks,
Manaf

> > > +				hysteresis = <5000>;
> > > +				type = "hot";
> > > +			};
> > > +		};
> > > +	};
> > > +
> > > +	ec-keyboard {
> > > +		polling-delay = <10000>;
> > > +		thermal-sensors = <&ec 1>;
> > > +
> > > +		trips {
> > > +			trip-point0 {
> > > +				temperature = <90000>;
> > Likewise
> >
> > Konrad