Re: [PATCH] staging: greybus: Add newlines to sysfs output
From: Daniel West
Date: Mon Nov 02 2026 - 13:34:49 EST
On Wed, Oct 28, 2026 at 05:19:45AM +0100, Greg KH wrote:
> On Tue, Oct 27, 2026 at 06:31:40PM -0400, Daniel West wrote:
> > >From 6376e59cb4d0fa2d57ff7f4fb2ce6cdb8bb1d03a Mon Sep 17 00:00:00 2001
> > From: Daniel West <daniel.west.dev@xxxxxxxxx>
> > Date: Tue, 27 Oct 2026 15:53:19 -0400
> > Subject: [PATCH] staging: greybus: Add newlines to sysfs output
>
> This shouldn't be here in the body of the email, right?
>
> >
> > Add terminating newlines to the sysfs_emit attributes in the Greybus audio manager per warnings from checkpatch.
>
> Didn't checkpatch warn you about too long of lines here?
>
> >
> > WARNING: return sysfs_emit(...) formats should include a terminating newline
>
> Please read the archives for why this warning is ok to ignore here.
>
> thanks,
>
> greg k-h
Thank you very much for the contructive feedback. I have reviewed
the archives and it makes sense. I will drop the patch.
Thanks again,
Daniel W