Re: [PATCH] staging: greybus: Add newlines to sysfs output

From: David Laight

Date: Thu Nov 05 2026 - 04:13:47 EST


On Wed, 28 Oct 2026 05:19:45 +0100
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

...
> > WARNING: return sysfs_emit(...) formats should include a terminating newline
>
> Please read the archives for why this warning is ok to ignore here.

I was contemplating a patch to the sysfs code add missing '\n' and
also remove trailing ", ;" that come from generating lists.
It would make a lot of code a lot simpler.

I found one place that puts binary data into the buffer (horrid).
(I have a plan for that.)

So why is this one special, there is nothing in the commit messages.

David