Re: [PATCH] staging: fbtft: fix space prohibited before that close parenthesis
From: Andy Shevchenko
Date: Mon Nov 02 2026 - 15:45:31 EST
On Sat, Oct 31, 2026 at 6:23 AM Eric LI <eric.lee0305@xxxxxxxxx> wrote:
>
> Clean up the following checkpatch error and warning in fbtft-bus.c.
> drivers/staging/fbtft/fbtft-bus.c:14: WARNING: macros should not use a trailing semicolon
> drivers/staging/fbtft/fbtft-bus.c:65: ERROR: space prohibited before that close parenthesis ')'
> drivers/staging/fbtft/fbtft-bus.c:67: ERROR: space prohibited before that close parenthesis ')'
>
> The reason of that error is the modifier argument is optional to the
> macro define_fbtft_write_reg. So, even if removing the space before close
> parenthesis, another error "space required after that ','" occurs.
>
> In this fix, I change that modifier argument as optional, so that
> it is both ok to use that macro with or without modifier argument.
It's not a fix, it does not fix anything.
Also study the mailing list archive (lore.kernel.org) to see what
happened to the similar patches in the past.
--
With Best Regards,
Andy Shevchenko