Re: [PATCH] staging: fbtft: fix space prohibited before that close parenthesis

[Eric Lee]

On Nov 3, 2026, at 04:44, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> 
> It's not a fix, it does not fix anything.
> Also study the mailing list archive (lore.kernel.org) to see what
> happened to the similar patches in the past.

Thanks for your feedback. I did check the mailing list archive for the same
Checkpatch error in staging/fbtft.

They either removed the extra space between ‘,’ and ‘)’ that caused another
checkpatch error “space required after that ‘,’”,
or removed both ‘,’ and extra space before ‘)’ that caused build error.

The key difference in my change here is to make that argument “modifier” as
variable argument, not a positional argument anymore. After that, I could
safely remove both ‘,’ and extra space before  ‘)’, without further checkpatch
error.

It passed my build and verificaton based on the file "fbtft-bus.i”.

It is fine for me if you think that it is not worth removing that checkpatch error.

--
Best Regard,
Eric LI