Re: [PATCH net] selftests: drv-net: pause: Skip support tests without link autonegotiation

[Mohsin Bashir]

On 10/30/26 1:12 PM, Andrew Lunn wrote:
> > > Or maybe a bit more clever, have a quick check to see if the device accepts
> > > an ethtool -s XXX command ? looks like fbnic will refuse all of'em as it
> > > doesn't have a .set_link_ksettings.
> >
> > Yes, checking whether the DUT accepts ethtool -s is one options. We could
> > reuse the existing autonegotiated and forced-link attempts, and report SKIP
> > if neither allows pause checks to run. Alternatively, we can add a remote
> > arg to require_link_autoneg(), default to True, and pass False for this test
> > so it checks only the DUT’s autonegotiation support.
>
> There is a subset of pause configurations which don't require autoneg.
>
> ethtool --pause eth42 autoneg off [rx on|off] [tx on|off]
>
> These can be implemented by a device which does not support
> autoneg. These setting go straight to the MAC. They are never
> negotiated.
>
> 	 Andrew

Hi Andrew,

Right. The autoneg setup and MAC pause checks need to be decoupled. Let 
me respin the fix.