Re: [PATCH][next] perf cs-etm: Fix spelling mistake "should't" -> "shouldn't"

[James Clark]

On 02/11/2026 18:01, Ian Rogers wrote:
> On Mon, Nov 2, 2026 at 2:52 AM James Clark <james.clark@xxxxxxxxxx> wrote:
> > On 28/10/2026 18:31, Colin Ian King wrote:
> > > There is a spelling mistake in a pr_err error message. Fix it.
> > >
> > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> > > ---
> > >    tools/perf/util/cs-etm.c | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> > > index bdcf94813129..65bce2450549 100644
> > > --- a/tools/perf/util/cs-etm.c
> > > +++ b/tools/perf/util/cs-etm.c
> > > @@ -434,7 +434,7 @@ static int cs_etm__map_unformatted_trace_ids(struct cs_etm_auxtrace *etm)
> > >                        continue;
> > >
> > >                if (!intlist__empty(etmq->traceid_list)) {
> > > -                     pr_err("CS_ETM: Unformatted queue should't have trace ID\n");
> > > +                     pr_err("CS_ETM: Unformatted queue shouldn't have trace ID\n");
> > >                        return -EINVAL;
> > >                }
> >
> > Reviewed-by: James Clark <james.clark@xxxxxxxxxx>
>
> I was curious how this passed Sashiko's review. Did Sashiko flag the
> spelling mistake but the fix was missed, or did Sashiko not flag it at
> all?
>
> Thanks!
> Ian

It reviewed it, but it didn't flag it. What kind of typos is it supposed 
to look for? I haven't seen it flag one before.

I have a spellchecker in my IDE which didn't catch it either because 
should is correct and t is only 1 letter. Maybe there is a setting I can 
tweak.